8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
bot
added
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is backport of "JDK-8365098 make/RunTests.gmk generates a wrong path to test artifacts on Alpine" as JDK11 tests have the same issue on Alpine - generate a wrong path to test artifacts.
However, there are still vendors which still build jdk11 and below for Solaris, so I added the cross platfrom fix here, using a combination of SED and TR.
So, the backport isn't clean. (Build system fix, test artifacts path processing.)
I'm not sure, if I may request for integration as a backport, or should I create new JBS bug to cover this (starting from the upstream).
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3125/head:pull/3125$ git checkout pull/3125Update a local copy of the PR:
$ git checkout pull/3125$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3125/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3125View PR using the GUI difftool:
$ git pr show -t 3125Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3125.diff
Using Webrev
Link to Webrev Comment